[#742] Writer + Reader tab v10: active tag, portfolio boxes, donation boxes#743
[#742] Writer + Reader tab v10: active tag, portfolio boxes, donation boxes#743realproject7 merged 2 commits intomainfrom
Conversation
… donation boxes 1. Move active/complete tag after deadline counter (Deadline: 1d 7h · active) 2. Reader Portfolio summary: 4-box grid (PLOT value, USD, Holdings, Best 24h) 3. Reader Donations: bordered box layout (Received, Given) with per-story rows below Fixes #742 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
There was a problem hiding this comment.
T2b REQUEST CHANGES — 1 issue found.
Items 2 and 3 (Portfolio 4-box grid, Donation boxes) look correct.
Issue: Unconditional dot separator in deadline row (~line 922)
The dot separator is now rendered unconditionally, but for complete stories (sunset=true) there is no DeadlineCountdown preceding it. This renders as "· complete" with a leading dot and nothing before it.
Fix: wrap the dot inside the DeadlineCountdown conditional:
{!storyline.sunset && storyline.last_plot_time && (
<>
<DeadlineCountdown lastPlotTime={storyline.last_plot_time} />
<span className="text-muted">·</span>
</>
)}Everything else is clean — single file, net -5 lines, box layouts match Writer Stats pattern.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The Reader dashboard box changes look aligned with issue #742, but the Writer deadline-row tweak introduces a regression for completed stories.
Findings
- [medium] The deadline separator is now unconditional, so completed stories render a leading
· completeeven when there is no countdown. Issue #738 previously required sunset/complete stories to show justcompleteplus the created date, and this change regresses that state.- File:
src/app/profile/[address]/page.tsx:925 - Suggestion: only render the separator when a deadline countdown is present, so active rows read
Deadline: … · activebut complete rows staycomplete.
- File:
Decision
Requesting changes because the active-tag placement is fixed, but the completed-storyline layout now regresses.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE — re-reviewed after fix. Dot separator now correctly inside the DeadlineCountdown conditional. Complete stories render just "complete" without leading dot. All 3 items verified:
- Active tag after deadline: "Deadline: Xd Xh Xm · active" ✓
- Reader Portfolio 4-box grid (PLOT/USD/Holdings/Best 24h) ✓
- Reader Donations bordered box layout (Received/Given) ✓
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up fix resolves the completed-story regression. The deadline row now reads Deadline: … · active for active stories while completed stories remain just complete, and the Reader portfolio/donation dashboard box changes still match issue #742.
Findings
- None.
Decision
Approving because the review blocker is addressed and I do not see a remaining code-level mismatch against the ticket.
Summary
Fixes #742
Test plan
🤖 Generated with Claude Code